Deflakes Primary COB growth with inactive replica #2715
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sarthak Aggarwal <[email protected]>
sarthakaggarwal97
force-pushed
the
cob-growth-test-fix
branch
from
f9f94d9 to
db6e772
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #2715 +/- ##
============================================
+ Coverage 72.40% 72.62% +0.21%
============================================
Files 128 128
Lines 71273 71273
============================================
+ Hits 51606 51759 +153
+ Misses 19667 19514 -153 🚀 New features to boost your workflow:
|
|
@enjoy-binbin thank you for taking a look, I shared my thought process in the PR description, please let me know if it doesn't makes sense! |
enjoy-binbin
approved these changes
Oct 16, 2025
diego-ciciani01
pushed a commit
to diego-ciciani01/valkey
that referenced
this pull request
Oct 21, 2025
Resolves valkey-io#2696 The primary issue was that with sanitizer mode, the test needed more time for primary’s replication buffers grow beyond `2 × backlog_size`. Increasing the threshold of `repl-timeout` to 30s, ensures that the inactive replica is not disconnected while the full sync is proceeding. `rdb-key-save-delay` controls or throttles the data written to the client output buffer, and in this case, we are deterministically able to perform the fullsync within 10s (10000 keys * 0.001s). Increasing the `wait_for_condition` gives it enough retries to verify that `mem_total_replication_buffers` reaches the required `2 × backlog_size`. Signed-off-by: Sarthak Aggarwal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2696
The primary issue was that with sanitizer mode, the test needed more time for primary’s replication buffers grow beyond
2 × backlog_size. Increasing the threshold ofrepl-timeoutto 30s, ensures that the inactive replica is not disconnected while the full sync is proceeding.rdb-key-save-delaycontrols or throttles the data written to the client output buffer, and in this case, we are deterministically able to perform the fullsync within 10s (10000 keys * 0.001s).Increasing the
wait_for_conditiongives it enough retries to verify thatmem_total_replication_buffersreaches the required2 × backlog_size.The test is passing for past 7 consecutive iterations for
test-sanitizer-addressin my daily runs. I amended log to show the current backlog if it doesn't reach 2x.